bazel: set PATH automatically on macOS#17467
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Jul 23, 2021
Merged
Conversation
Previously there was a docs recommendation to set the path manually when building on macOS. Since we can use the `build:macos` config we can do this automatically. This also allows us to transparently solve PATH differences with Apple Silicon homebrew and intel homebrew, for the host configuration as well. This fixes this issue bazel-contrib/rules_foreign_cc#672 that intel homebrew didn't have because `--incompatible_strict_action_env` contains `/usr/local/bin` but not `/opt/homebrew/bin` This also reorders these so that we prefer pre-installed tools for stability. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
force-pushed
the
ks/bazel-set-path-automatically-on-macos
branch
from
73c7707 to
d9ec25d
Compare
htuch
approved these changes
Jul 23, 2021
Contributor
|
looking better already, right @carlocab! |
|
Better -- however it doesn't work for users who want to build Envoy from source and have a Homebrew-installation in a non-default prefix... |
Member
|
I think there are limits on what we can do automagically. Best to address non-default installations with explicit instructions on how to set PATH via |
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Previously there was a docs recommendation to set the path manually when building on macOS. Since we can use the `build:macos` config we can do this automatically. This also allows us to transparently solve PATH differences with Apple Silicon homebrew and intel homebrew, for the host configuration as well. This fixes this issue bazel-contrib/rules_foreign_cc#672 that intel homebrew didn't have because `--incompatible_strict_action_env` contains `/usr/local/bin` but not `/opt/homebrew/bin` This also reorders these so that we prefer pre-installed tools for stability. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously there was a docs recommendation to set the path manually when
building on macOS. Since we can use the
build:macosconfig we can dothis automatically. This also allows us to transparently solve PATH
differences with Apple Silicon homebrew and intel homebrew, for the host
configuration as well.
This fixes this issue
bazel-contrib/rules_foreign_cc#672 that intel
homebrew didn't have because
--incompatible_strict_action_envcontains/usr/local/binbut not/opt/homebrew/binThis also reorders these so that we prefer pre-installed tools for
stability.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com