bazel: remove old luajit workaround#17466
Merged
wrowe merged 1 commit intoenvoyproxy:mainfrom Jul 26, 2021
Merged
Conversation
Member
Author
|
@moderation wdyt? |
Contributor
|
LGTM. I commented these lines out when I got M1 building a while back - #16482 (comment) Removing as we don't require makes sense. MacOS CI failing however |
According to https://luajit.org/install.html > Important: this relates to LuaJIT 2.0 only — use LuaJIT 2.1 to avoid these complications. Since we have updated past 2.1 we shouldn't need these anymore which is great since it breaks on Apple Silicon envoyproxy#16482 (comment) Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
force-pushed
the
ks/bazel-remove-old-luajit-workaround
branch
from
0c20302 to
6699c9a
Compare
Member
Author
|
Yea I just noticed that we can probably remove them instead. Turns out I can't let the options fallthrough, hopefully green now |
wrowe
approved these changes
Jul 26, 2021
Contributor
wrowe
left a comment
wrowe
left a comment
There was a problem hiding this comment.
Looks appropriate, taking your word as the SME on this logic. TY
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
According to https://luajit.org/install.html > Important: this relates to LuaJIT 2.0 only — use LuaJIT 2.1 to avoid these complications. Since we have updated past 2.1 we shouldn't need these anymore which is great since it breaks on Apple Silicon envoyproxy#16482 (comment) Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://luajit.org/install.html
Since we have updated past 2.1 we shouldn't need these anymore which is
great since it breaks on Apple Silicon
#16482 (comment)
Signed-off-by: Keith Smiley keithbsmiley@gmail.com