Skip to content

Fix yaml example in api#17462

Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
nezdolik:fix-docs
Jul 23, 2021
Merged

Fix yaml example in api#17462
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
nezdolik:fix-docs

Conversation

@nezdolik
Copy link
Copy Markdown
Member

Signed-off-by: Kateryna Nezdolii nezdolik@spotify.com

Commit Message:
Additional Description: Name is required field for original_ip_detection_extensions, pasting example as it is fails in proto validation step.
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #17462 was opened by nezdolik.

see: more, trace.

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @nezdolik

@mattklein123 mattklein123 merged commit 550e4ad into envoyproxy:main Jul 23, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants