config: allow .yml files to load as YAML#17455
Merged
mattklein123 merged 4 commits intomainfrom Jul 23, 2021
Merged
Conversation
This is a common source of user confusion. Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
lakamsani
added a commit
to lakamsani/envoy
that referenced
this pull request
Jul 22, 2021
…x it via envoyproxy#17455 Signed-off-by: vamsee.lakamsani <lakamsani@gmail.com>
htuch
previously approved these changes
Jul 23, 2021
| TEST_P(DynamicValidationIntegrationTest, CdsProtocolOptionsRejected) { | ||
| api_filesystem_config_ = { | ||
| "test/config/integration/server_xds.bootstrap.yaml", | ||
| "test/config/integration/server_xds.bootstrap.yml", |
Member
There was a problem hiding this comment.
Optional nit: technically an orthogonal test for this would be cleaner, but not that big a deal.
soulxu
reviewed
Jul 23, 2021
source/common/protobuf/utility.cc
Outdated
| } | ||
| if (absl::EndsWith(path, FileExtensions::get().Yaml)) { | ||
| if (absl::EndsWith(path, FileExtensions::get().Yaml) || | ||
| absl::EndsWith(path, FileExtensions::get().Yml)) { |
Member
There was a problem hiding this comment.
maybe using absl::EndsWithIgnoreCase is better, feel loose check better than strict check here. But yes, this isn't the scope of this PR also.
Member
Author
There was a problem hiding this comment.
Yeah this is a good idea. I will do this and a few more tests per @htuch
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
This is a common source of user confusion. Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a common source of user confusion.
Risk Level: Low
Testing: Modified tests
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A