access log: fix %UPSTREAM_CLUSTER% in upstream http access logs#17453
Merged
htuch merged 3 commits intoenvoyproxy:mainfrom Jul 23, 2021
Merged
access log: fix %UPSTREAM_CLUSTER% in upstream http access logs#17453htuch merged 3 commits intoenvoyproxy:mainfrom
htuch merged 3 commits intoenvoyproxy:mainfrom
Conversation
This has been broken for several versions, possibly by commit 980c84d. Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…yproxy#17453) This has been broken for several versions, possibly by commit 980c84d. Risk Level: Low Testing: Added new test Signed-off-by: Greg Greenway <ggreenway@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Greg Greenway ggreenway@apple.com
Commit Message:
Additional Description: This has been broken for several versions, possibly by
commit 980c84d.
Risk Level: Low
Testing: Added new test
Docs Changes: none
Release Notes: added
Platform Specific Features: none
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]