Skip to content

Remove hidden_envoy_deprecated_idle_timeout#17451

Merged
htuch merged 2 commits intoenvoyproxy:mainfrom
tyxia:idletimeout
Jul 23, 2021
Merged

Remove hidden_envoy_deprecated_idle_timeout#17451
htuch merged 2 commits intoenvoyproxy:mainfrom
tyxia:idletimeout

Conversation

@tyxia
Copy link
Copy Markdown
Member

@tyxia tyxia commented Jul 22, 2021

Signed-off-by: Tianyu Xia tyxia@google.com

Risk Level: LOW
Testing: CI

Signed-off-by: Tianyu Xia <tyxia@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #17451 was opened by tyxia.

see: more, trace.

@tyxia tyxia changed the title Remove hidden_envoy_deprecated_idle_timeout Remove hidden_envoy_deprecated_idle_timeout Jul 22, 2021
`CommonHttpProtocolIdleTimeout`

Signed-off-by: Tianyu Xia <tyxia@google.com>
@tyxia tyxia marked this pull request as ready for review July 22, 2021 18:50
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 2f13487 into envoyproxy:main Jul 23, 2021
@tyxia tyxia deleted the idletimeout branch July 23, 2021 03:39
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Risk Level: LOW
Testing: CI

Signed-off-by: Tianyu Xia <tyxia@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants