Skip to content

bazel: add darwin_arm64 to apple config group#17444

Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
keith:ks/bazel-add-darwin_arm64-to-apple-config-group
Jul 22, 2021
Merged

bazel: add darwin_arm64 to apple config group#17444
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
keith:ks/bazel-add-darwin_arm64-to-apple-config-group

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Jul 22, 2021

This is the CPU you target when building on an Apple Silicon mac. All
the apple settings should apply.

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

This is the CPU you target when building on an Apple Silicon mac. All
the apple settings should apply.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@moderation
Copy link
Copy Markdown
Contributor

Aligns with what I found at #16482 (comment) 👍

@mattklein123 mattklein123 merged commit 9f05912 into envoyproxy:main Jul 22, 2021
@keith keith deleted the ks/bazel-add-darwin_arm64-to-apple-config-group branch July 23, 2021 16:45
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
This is the CPU you target when building on an Apple Silicon mac. All
the apple settings should apply.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants