Skip to content

docs: fix typo in listener filter chain match configuration example#17398

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
zhxie:typo-listener-components
Jul 19, 2021
Merged

docs: fix typo in listener filter chain match configuration example#17398
phlax merged 1 commit intoenvoyproxy:mainfrom
zhxie:typo-listener-components

Conversation

@zhxie
Copy link
Copy Markdown
Contributor

@zhxie zhxie commented Jul 19, 2021

Signed-off-by: Xie Zhihao zhihao.xie@intel.com

Commit Message: docs: fix typo in listener filter chain match configuration example
Additional Description: the destination_port_range's end field is exclusive
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
@repokitteh-read-only
Copy link
Copy Markdown

Hi @zhxie, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #17398 was opened by zhxie.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy[\w/]*/(v1alpha\d?|v1|v2alpha\d?|v2))|(api/envoy/type/(matcher/)?\w+.proto).
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #17398 was opened by zhxie.

see: more, trace.

@markdroth
Copy link
Copy Markdown
Contributor

/lgtm api

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @zhxie

@markdroth
Copy link
Copy Markdown
Contributor

/lgtm v2-freeze

@phlax phlax self-assigned this Jul 19, 2021
@phlax phlax merged commit 396892c into envoyproxy:main Jul 19, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
@zhxie zhxie deleted the typo-listener-components branch September 7, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants