kafka: add stub classes for mesh filter#17374
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Jul 22, 2021
Merged
Conversation
Contributor
Author
|
Let's run builds for now, most probably something will be red and I'll notice some more places to add comments. |
adamkotwasinski
force-pushed
the
filter-stub
branch
from
44a9083 to
4658e54
Compare
adamkotwasinski
force-pushed
the
filter-stub
branch
from
4658e54 to
25c3886
Compare
adamkotwasinski
force-pushed
the
filter-stub
branch
from
25c3886 to
d991d7d
Compare
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
filter-stub
branch
from
d991d7d to
752fc04
Compare
adamkotwasinski
commented
Jul 19, 2021
| * Represents single downstream client request. | ||
| * Responsible for performing the work on multiple upstream clusters and aggregating the results. | ||
| */ | ||
| class InFlightRequest { |
Contributor
Author
There was a problem hiding this comment.
Implementations of this interface will provide the proper handling to provide kafka-mesh features.
To have basic compliance with protocol we will require to handle the following types (these are links to stuff that will appear in "future PRs"):
adamkotwasinski
commented
Jul 19, 2021
|
|
||
| void RequestProcessor::onMessage(AbstractRequestSharedPtr arg) { | ||
| // This will be replaced with switch on header's API key. | ||
| throwOnUnsupportedRequest("unsupported (bad client API invoked?)", arg->request_header_); |
Contributor
Author
There was a problem hiding this comment.
When arg can be actually turned into instance of InFlightRequest then we can go back to filter.
Rough impl (needs some merging): link
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
changed the title
mattklein123
approved these changes
Jul 22, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks. Since this extension is going to get moved to contrib I quickly skimmed and am going to merge.
Merged
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: kafka: add stub classes for mesh filter
Additional Description: stub for Kafka mesh filter
creates a new filter object, abstraction for in-flight request, very simple request processor (that doesn't process any of requests); provides generic logic of how the mesh will work on a high level:
Risk Level: low, code cannot be referenced as it doesn't have an extension
Testing: unit tests right now
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a