Add local_end_stream_ to crash dump for H1#17367
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom Jul 19, 2021
Merged
Conversation
Signed-off-by: Pradeep Rao <pcrao@google.com>
alyssawilk
reviewed
Jul 15, 2021
| !active_request_.value().request_url_.getStringView().empty() | ||
| ? active_request_.value().request_url_.getStringView() | ||
| : "null"); | ||
| os << DUMP_MEMBER_AS( |
Contributor
There was a problem hiding this comment.
Thanks so much for adding this extra state to the dump.
Instead of adding a second bunch of messy code, what do you think of having a dumpState function for the active request, and then just calling DUMP_DETAILS(active_request_)
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion Alyssa, I will implement this.
Signed-off-by: Pradeep Rao <pcrao@google.com>
alyssawilk
approved these changes
Jul 19, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Yeah, looks great!
the only problem is coverage flaked. Let me see if I can get a clean run to merge
/retest
|
Retrying Azure Pipelines: |
Contributor
Author
|
Thanks so much Alyssa, hope it passes on rerun. |
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Risk Level: low Testing: unit test improvements Docs Changes: n/a Release Notes: n/a Signed-off-by: Pradeep Rao <pcrao@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pradeep Rao pcrao@google.com
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]