tooling: Add misc contextmanagers/decorators#17360
Merged
phlax merged 3 commits intoenvoyproxy:mainfrom Jul 16, 2021
Merged
Conversation
phlax
force-pushed
the
tooling-misc
branch
3 times, most recently
from
e7e6831 to
20fc22d
Compare
repokitteh-read-only
bot
added
the
deps
Member
Author
|
coverage is here https://storage.googleapis.com/envoy-pr/17360/tooling/index.html |
phlax
changed the title
phlax
force-pushed
the
tooling-misc
branch
2 times, most recently
from
f94ce13 to
772f27f
Compare
phlax
changed the title
phlax
commented
Jul 15, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
mattklein123
approved these changes
Jul 16, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: tooling: Add misc contextmanagers/decorators
Additional Description:
A breakout PR from #17336 and #17289 , with utils to:
runner.Runnerthat catches errors, logs and returns 1 for sys.exitRisk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]