listener: extract active_tcp_socket and active_stream_listener_base#17355
listener: extract active_tcp_socket and active_stream_listener_base#17355mattklein123 merged 29 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <lambdai@google.com>
Signed-off-by: Yuchen Dai <lambdai@google.com>
Signed-off-by: Yuchen Dai <lambdai@google.com>
Signed-off-by: Yuchen Dai <lambdai@google.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
and push up Network::Connection op Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
…dai into addinternallistener_pre_1
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
…re_1 Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
Check CI? /wait |
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
Ahrr, Add a setting to my vscode |
mattklein123
left a comment
There was a problem hiding this comment.
Can you summarize what code you actually changed vs. moved? What do I need to review?
/wait-any
Sure.
The goal is to avoid duplicating the ActiveTcpListener when a ActiveInternalListener is added. Without the context of the above goal, this PR should be small win regarding the achievement of less coupling between ActiveTcpSocket and ActiveTcpListener. |
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, generally makes sense with some random comments.
/wait
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
fixing conflict |
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
OK LGTM pending the other open comment thread about moving to protected, thanks. /wait |
I had the illusion it is done. Now I am trying to move to protected and I realize it was public even before this PR. This things I am doing is:
|
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
…nvoyproxy#17355) Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Commit Message:
Split from #16947
Extract ActiveTcpSocket from ActiveTcpListener.
Extract a base class ActiveStreamListener from ActiveTcpListener.
Additional Description:
The new base class owns the the active sockets that drive itself through the listener filters.
After the active socket passes all the listener filters, a server connection is created. As a derived listener,
ActiveTcpListener overrides
newActiveConnectionto take the ownership of that server connection.Risk Level: LOW
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]