Revert connection pool cleanup#17319
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Jul 13, 2021
Merged
Conversation
This reverts commit 3876d7c. Signed-off-by: Greg Greenway <ggreenway@apple.com>
ggreenway
added a commit
to ggreenway/envoy
that referenced
this pull request
Jul 19, 2021
Delete connection pools when they have no connections anymore. This fixes unbounded memory use for cases where a new connection pool is needed for each downstream connection, such as when using upstream PROXY protocol. Fixes envoyproxy#16682 This reverts commit b7bc539. This reverts PR envoyproxy#17319, by re-adding envoyproxy#17302 and envoyproxy#16948. Signed-off-by: Greg Greenway <ggreenway@apple.com> Co-authored-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
mum4k
added a commit
to mum4k/nighthawk
that referenced
this pull request
Jul 20, 2021
- no changes in `.bazelrc`, `.bazelversion` or `ci/run_envoy_docker.sh`. - reverting the `addIdleCallback` connection pool method back to `addDrainedCallback` as per envoyproxy/envoy#17319. - changing method call `AsyncClientFactory::create()` to `AsyncClientFactory::createUncachedRawAsyncClient()` as per envoyproxy/envoy#15745. Signed-off-by: Jakub Sobon <mumak@google.com>
mum4k
added a commit
to envoyproxy/nighthawk
that referenced
this pull request
Jul 20, 2021
- no changes in `.bazelrc`, `.bazelversion` or `ci/run_envoy_docker.sh`. - reverting the `addIdleCallback` connection pool method back to `addDrainedCallback` as per envoyproxy/envoy#17319. - changing method call `AsyncClientFactory::create()` to `AsyncClientFactory::createUncachedRawAsyncClient()` as per envoyproxy/envoy#15745. Signed-off-by: Jakub Sobon <mumak@google.com>
ggreenway
added a commit
that referenced
this pull request
Jul 26, 2021
Delete connection pools when they have no connections anymore. This fixes unbounded memory use for cases where a new connection pool is needed for each downstream connection, such as when using upstream PROXY protocol. This reverts commit b7bc539. This reverts PR #17319, by re-adding #17302 and #16948. Signed-off-by: Greg Greenway <ggreenway@apple.com> Co-authored-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Delete connection pools when they have no connections anymore. This fixes unbounded memory use for cases where a new connection pool is needed for each downstream connection, such as when using upstream PROXY protocol. This reverts commit b7bc539. This reverts PR envoyproxy#17319, by re-adding envoyproxy#17302 and envoyproxy#16948. Signed-off-by: Greg Greenway <ggreenway@apple.com> Co-authored-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Revert #17302 and #16948. There have been multiple crashes reported. Will try again later, at an earlier point in the release cycle.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]