repokitteh: adding warning about draft PRS#17063
Conversation
|
unfortunately not yet :( i don't see any warning in this pr though? |
|
@alyssawilk im a bit confused by this pr - as @itayd said i dont see any warning - and im struggling to understand the connection to repokitteh as this change is to the github notifier |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
whoops, I had two branches named draft in 2 different trees and pushed the wrong one. |
|
|
||
| """ | ||
|
|
||
| DRAFT_MESSAGE = """ |
There was a problem hiding this comment.
i think we should perhaps just include this in the main message
the reason being that until recently i didnt discover how to create a draft pr - so habitually created a non-draft and then marked it so
There was a problem hiding this comment.
hmmm - altho i guess this also sends a message to non-new-contributors - which is kinda confusing given the name of this module
There was a problem hiding this comment.
yeah, if someone has contributed a few times and then does a draft I think they should get the warning. I don't think there is a hook for "has ever done a draft before" so it's all or nothing.
moved the module for clarity
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
lgtm - we'll have to "first song sound check" with it i reckon as no easy way to test repokitteh
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Updating contributing docs as well Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: chris.xin <xinchuantao@qq.com>
Updating contributing docs as well Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
3 participants
Hey @itayd is there a better way to test this works than submitting and creating a draft PR? :-)