bazel: Fix pch timestamp issues#17030
Merged
jmarantz merged 1 commit intoenvoyproxy:mainfrom Jun 18, 2021
Merged
Conversation
Previously I thought it wasn't safe to pass this because it wasn't in a shipped version of clang yet but it turns out I wasn't using `-Xclang`. This solves an issue where if you build a pch, then `touch` a header file that's included in it without actually changing contents, including the pch would fail. Now we let bazel handle that and since it doesn't use timestamps it's a bit smarter about it. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
jmarantz
approved these changes
Jun 18, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Previously I thought it wasn't safe to pass this because it wasn't in a shipped version of clang yet but it turns out I wasn't using `-Xclang`. This solves an issue where if you build a pch, then `touch` a header file that's included in it without actually changing contents, including the pch would fail. Now we let bazel handle that and since it doesn't use timestamps it's a bit smarter about it. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously I thought it wasn't safe to pass this because it wasn't in a
shipped version of clang yet but it turns out I wasn't using
-Xclang.This solves an issue where if you build a pch, then
toucha headerfile that's included in it without actually changing contents, including
the pch would fail. Now we let bazel handle that and since it doesn't
use timestamps it's a bit smarter about it.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com