Closed
Conversation
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Contributor
|
Tianyu: can you take a pass? |
tyxia
requested changes
Jun 17, 2021
Member
There was a problem hiding this comment.
Thank you for working on this!
I think this PR is not in the direction we want: We are removing the v2 support. v2 hidden_envoy_deprecated_hosts and related support were removed in #16931. But this PR is adding this field back.
We should also sync on this task in the future to avoid duplicated work :)
Contributor
Author
|
@tyxia hope you are in slack for in sync for this activitiy . i will coordinate there |
Member
Sure. My slack user name is tyxia. Feel free to ping me. I think you can drop this PR then. |
Contributor
Author
|
@tyxia Yeah... |
Contributor
Author
|
Hi @tyxia I could see 2 username with same name ... pls suggest which one to use
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhay Narayan Katare abhay.katare@india.nec.com
Commit Message: Remove support for v2 hosts
Additional Description: Another PR of type remove_v2_support. first PR is #16274
Risk Level: LOW
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]