ci: support custom TEST_TMPDIR and clang-format#17020
Merged
phlax merged 2 commits intoenvoyproxy:mainfrom Jun 21, 2021
Merged
Conversation
Signed-off-by: Long Dai <long0dai@foxmail.com>
Contributor
|
Drive-by comment: what's broken about the current support for TEST_TMPDIR and clang-format? |
Member
I think it's probably two things: a) being able to set TEST_TMPDIR externally (at call time maybe) b) This ensures LLVM's binaries are actually in $PATh |
rgs1
previously approved these changes
Jun 17, 2021
Member
rgs1
left a comment
rgs1
left a comment
There was a problem hiding this comment.
This looks reasonable to me, once CI passes.
Member
Author
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Long Dai <long0dai@foxmail.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Long Dai <long0dai@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Long Dai long0dai@foxmail.com
Commit Message:
Fix hardcode val for TEST_TMPDIR and llvm.
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]