Skip to content

remove invalid corpus that contains use_tcp_for_dns_lookup in bootstrap proto#17011

Closed
chaoqin-li1123 wants to merge 1 commit intoenvoyproxy:mainfrom
chaoqin-li1123:remove_invalid_corpus
Closed

remove invalid corpus that contains use_tcp_for_dns_lookup in bootstrap proto#17011
chaoqin-li1123 wants to merge 1 commit intoenvoyproxy:mainfrom
chaoqin-li1123:remove_invalid_corpus

Conversation

@chaoqin-li1123
Copy link
Copy Markdown
Contributor

Signed-off-by: chaoqin-li1123 chaoqinli@google.com

Commit Message: #16237 deprecate the use_tcp_for_dns_lookup field in bootstrap.proto, which makes these corpus invalid.
Additional Description:N/A
Risk Level:low
Testing:remove fuzz corpus
Docs Changes:N/A
Release Notes:N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
@jmarantz
Copy link
Copy Markdown
Contributor

/assign-from @envoyproxy/maintainers

@repokitteh-read-only
Copy link
Copy Markdown

@envoyproxy/maintainers assignee is @ggreenway

🐱

Caused by: a #17011 (comment) was created by @jmarantz.

see: more, trace.

@ggreenway ggreenway assigned asraa and unassigned ggreenway Jun 21, 2021
@ggreenway
Copy link
Copy Markdown
Member

@asraa can you take this? I'm unsure whether we should modify these to exclude that option now, make them use the replacement option, or delete entirely.

Copy link
Copy Markdown
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm what stops the fuzzer from crashing on this input again?

Does the fuzzer crash on this input? Does it throw a deprecation error that isn't caught (that it should be catching)?

@chaoqin-li1123
Copy link
Copy Markdown
Contributor Author

Hmmm what stops the fuzzer from crashing on this input again?

Does the fuzzer crash on this input? Does it throw a deprecation error that isn't caught (that it should be catching)?

We still have support for this deprecated field in the code base, so it won't crash on the input.

@lizan
Copy link
Copy Markdown
Member

lizan commented Jun 30, 2021

@asraa ?

@asraa
Copy link
Copy Markdown
Contributor

asraa commented Jun 30, 2021

So is this just a cleanup removing deprecated fields from testcases? Why not just remove the field instead of the corpus entry?

@chaoqin-li1123
Copy link
Copy Markdown
Contributor Author

So is this just a cleanup removing deprecated fields from testcases? Why not just remove the field instead of the corpus entry?

yeah, we can remove only the deprecated field.

@snowp snowp added the waiting label Jul 14, 2021
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants