remove invalid corpus that contains use_tcp_for_dns_lookup in bootstrap proto#17011
remove invalid corpus that contains use_tcp_for_dns_lookup in bootstrap proto#17011chaoqin-li1123 wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
|
/assign-from @envoyproxy/maintainers |
|
@envoyproxy/maintainers assignee is @ggreenway |
|
@asraa can you take this? I'm unsure whether we should modify these to exclude that option now, make them use the replacement option, or delete entirely. |
asraa
left a comment
There was a problem hiding this comment.
Hmmm what stops the fuzzer from crashing on this input again?
Does the fuzzer crash on this input? Does it throw a deprecation error that isn't caught (that it should be catching)?
We still have support for this deprecated field in the code base, so it won't crash on the input. |
|
@asraa ? |
|
So is this just a cleanup removing deprecated fields from testcases? Why not just remove the field instead of the corpus entry? |
yeah, we can remove only the deprecated field. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: chaoqin-li1123 chaoqinli@google.com
Commit Message: #16237 deprecate the use_tcp_for_dns_lookup field in bootstrap.proto, which makes these corpus invalid.
Additional Description:N/A
Risk Level:low
Testing:remove fuzz corpus
Docs Changes:N/A
Release Notes:N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]