Skip to content

support Apache SkyWalking tracer v8.6.0#17006

Merged
lizan merged 3 commits intoenvoyproxy:mainfrom
Shikugawa:skywalking-8.6-support
Jun 18, 2021
Merged

support Apache SkyWalking tracer v8.6.0#17006
lizan merged 3 commits intoenvoyproxy:mainfrom
Shikugawa:skywalking-8.6-support

Conversation

@Shikugawa
Copy link
Copy Markdown
Member

Signed-off-by: Shikugawa rei@tetrate.io

Commit Message: This PR updates cpp2sky to 0.2.2 and enable to use Apache SkyWalking v8.6.0
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Shikugawa <rei@tetrate.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 16, 2021
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #17006 was opened by Shikugawa.

see: more, trace.

@Shikugawa Shikugawa requested a review from moderation June 16, 2021 10:00
@moderation
Copy link
Copy Markdown
Contributor

Dependencies look OK but CI is failing on SkyWalking tests
/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jun 16, 2021
Copy link
Copy Markdown
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies look OK but your CI SkyWalking tests are failing

Signed-off-by: Shikugawa <rei@tetrate.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 17, 2021
Signed-off-by: Shikugawa <rei@tetrate.io>
@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jun 17, 2021
@Shikugawa
Copy link
Copy Markdown
Member Author

@lizan Could you take a look?

@moderation
Copy link
Copy Markdown
Contributor

LGTM from a deps point of view. Will need @lizan or senior maintainer to merge.

@lizan lizan merged commit c7c53b6 into envoyproxy:main Jun 18, 2021
@Shikugawa Shikugawa deleted the skywalking-8.6-support branch June 19, 2021 01:58
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Commit Message: This PR updates cpp2sky to 0.2.2 and enable to use Apache SkyWalking v8.6.0
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes:
Release Notes:

Signed-off-by: Shikugawa <rei@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants