test: fix health_check_integration test flake#16980
Merged
antoniovicente merged 1 commit intomainfrom Jun 15, 2021
Merged
Conversation
Advancing simulated time can race with arming the interval timer. Check for the next request a different way which does not flake. Signed-off-by: Matt Klein <mklein@lyft.com>
antoniovicente
approved these changes
Jun 14, 2021
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the fix.
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Advancing simulated time can race with arming the interval timer. Check for the next request a different way which does not flake. Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advancing simulated time can race with arming the interval timer.
Check for the next request a different way which does not flake.
Risk Level: Test only change
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A