http: forwarding transport failure details for CONNECT and ALPN connections#16975
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom Jun 21, 2021
Merged
http: forwarding transport failure details for CONNECT and ALPN connections#16975alyssawilk merged 2 commits intoenvoyproxy:mainfrom
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
Conversation
…ctions Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
requested review from
asraa,
ggreenway,
lizan and
zuercher
as code owners
zuercher
previously approved these changes
Jun 14, 2021
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Looks good! Is the plan to eventually remove the original conn pool or should we circle back and add failure reasons there?
Contributor
Author
|
yeah, we plan on removing it after the standard 6 months but it's not used for the aforementioned code paths (CONNECT/ALPN) in any case. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
(removing the bonus unrelated integration test as I broke it somewhere along the way and don't want to reflog it =P) |
zuercher
approved these changes
Jun 17, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…ctions (envoyproxy#16975) Previously, L7 connections forwarded over TCP didn't get connection failure details (auto_http before codec assignment, CONNECT requests during the entire lifetime) but now they should. Risk Level: low Testing: unit test. Docs Changes: n/a Release Notes: n/a Fixes #/16881 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, L7 connections forwarded over TCP didn't get connection failure details (auto_http before codec assignment, CONNECT requests during the entire lifetime) but now they should.
Risk Level: low
Testing: unit test.
Docs Changes: n/a
Release Notes: n/a
Fixes #/16881