Skip to content

Disable fuzz coverage test on Bazel CI#16940

Merged
antoniovicente merged 1 commit intoenvoyproxy:mainfrom
meteorcloudy:patch-2
Jun 14, 2021
Merged

Disable fuzz coverage test on Bazel CI#16940
antoniovicente merged 1 commit intoenvoyproxy:mainfrom
meteorcloudy:patch-2

Conversation

@meteorcloudy
Copy link
Contributor

#16542 has been keep Envoy red on Bazel CI for a long time, it doesn't make sense to keep a failing test if it's not going to be fixed.

@repokitteh-read-only
Copy link

Hi @meteorcloudy, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #16940 was opened by meteorcloudy.

see: more, trace.

@zuercher
Copy link
Member

@antoniovicente assign you because you seem to have some background based on the referenced issue.

@zuercher
Copy link
Member

@meteorcloudy it might be worth discussing the path forward with @antoniovicente first, but if we're going to proceed with this PR, we'll need DCO signoff (see https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md#dco-sign-your-work)

@antoniovicente
Copy link
Contributor

I really don't have context here. This coverage mode was introduced in #14179

I think you should reach out to @lizan, @asraa and @phlax .

Disabling for now SGTM.

envoyproxy#16542 has been keep Envoy red on Bazel CI for a long time, it doesn't make sense to keep a failing test if it's not going to be fixed.
Signed-off-by: Yun Peng <pcloudy@google.com>
Copy link
Contributor

@antoniovicente antoniovicente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to disable this in order to get the bazel CI back to a green state.

@antoniovicente antoniovicente merged commit acbd961 into envoyproxy:main Jun 14, 2021
@asraa
Copy link
Contributor

asraa commented Jun 15, 2021

That sounds good, as an aside I think the problem may be related to some libc++ flag configuration?

leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
envoyproxy#16542 has been keep Envoy red on Bazel CI for a long time, it doesn't make sense to keep a failing test if it's not going to be fixed.

Signed-off-by: Yun Peng <pcloudy@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants