stats: Add tests for StatsHandler::handlerStats()#16915
Merged
ggreenway merged 4 commits intoenvoyproxy:mainfrom Jun 21, 2021
Merged
stats: Add tests for StatsHandler::handlerStats()#16915ggreenway merged 4 commits intoenvoyproxy:mainfrom
ggreenway merged 4 commits intoenvoyproxy:mainfrom
Conversation
Contributor
Author
|
/assign @jmarantz |
Also a small Refactor of StatsHandler::handlerStats(). Signed-off-by: Ryan Hamilton <rch@google.com>
RyanTheOptimist
force-pushed
the
stats_handler_test
branch
from
8ec6116 to
3873ef8
Compare
Contributor
Author
jmarantz
reviewed
Jun 15, 2021
Contributor
|
/wait |
Signed-off-by: Ryan Hamilton <rch@google.com>
RyanTheOptimist
commented
Jun 16, 2021
Contributor
Author
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Thanks for the review. Sorry for the delay!
jmarantz
approved these changes
Jun 17, 2021
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
Looks great, with one minor nit.
/assign-from @envoyproxy/senior-maintainers
(there's a small prod refactor).
|
@envoyproxy/senior-maintainers assignee is @alyssawilk |
Contributor
Author
Thanks! What's the nit? |
jmarantz
previously approved these changes
Jun 17, 2021
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
Somehow this nit got lost. re-sending :)
| TestUtility::ipTestParamsToString); | ||
|
|
||
| TEST_P(AdminStatsTest, HandlerStatsInvalidFormat) { | ||
| std::string url = "/stats?format=blergh"; |
Contributor
Author
There was a problem hiding this comment.
Oh, good point! Done.
jmarantz
approved these changes
Jun 18, 2021
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
Looks great; over to Greg for senior maintainer stamp.
Contributor
Author
|
@ggreenway ping |
ggreenway
approved these changes
Jun 21, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Also a small Refactor of StatsHandler::handlerStats(). Signed-off-by: Ryan Hamilton <rch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stats: Add tests for StatsHandler::handlerStats()
Also a small Refactor of StatsHandler::handlerStats().
Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A