[WIP] build: Add debian/redhat packaging

[phlax]

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: build: Add debian packaging
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Partial fix for #16867
[Optional Deprecated:]
[Optional API Considerations:]

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16899 was opened by phlax.

see: more, trace.

[repokitteh-read-only]

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #16899 was synchronize by phlax.

see: more, trace.

[phlax]

@lizan this is still pretty wip, altho most of the parts are now ~working in a mvp way

i had a few ci and compiler questions that i hoped you would be able to assist with - questions in review...

[phlax]

im wondering what the best compile flags/options/etc are

[phlax]

ive added the packaging as a separate job after release - not sure how optimal that is

im wondering whether to either incorporate it with release or conversely to possibly incorporate it with what is currently the docker stage and make that to something like builds

[phlax]

as per the comment this could potentially run in parallel with the verifying of examples at the end

[djgilcrease]

might I recommend using https://github.com/goreleaser/nfpm to build rpm, Debian, and alpine packages.

[phlax]

afaict it doesnt have any bazel support - im pretty keen to standardize the tooling around bazel rules

[djgilcrease]

afaict it doesnt have any bazel support - im pretty keen to standardize the tooling around bazel rules

fair enough, I don't use bazel but I would be willing to try adding the support for it to nfpm.

Looking at the builds/BUILD from this PR it looks like I would want to add a bazel rule that would let you do something like

pkg_nfpm(
    name = "rpm_x64"
    nfpm_file = "envoy"
    pkg_type = "rpm"
    arch = "amd64"
    version = "1.19.0-pre"
)
pkg_nfpm(
    name = "rpm_arm64"
    nfpm_file = "envoy"
    pkg_type = "rpm"
    arch = "arm64"
    version = "1.19.0-pre"
)
pkg_nfpm(
    name = "deb_x64"
    nfpm_file = "envoy"
    pkg_type = "deb"
    arch = "amd64"
    version = "1.19.0-pre"
)
pkg_nfpm(
    name = "deb_arm64"
    nfpm_file = "envoy"
    pkg_type = "deb"
    arch = "arm64"
    version = "1.19.0-pre"
)
pkg_nfpm(
    name = "apk_x64"
    nfpm_file = "envoy"
    pkg_type = "apk"
    arch = "amd64"
    version = "1.19.0-pre"
)
pkg_nfpm(
    name = "apk_arm64"
    nfpm_file = "envoy"
    pkg_type = "apk"
    arch = "arm64"
    version = "1.19.0-pre"
)

if this sounds interesting I can get working on this.

[phlax]

if this sounds interesting I can get working on this.

it sounds interesting - but its not immediately clear what the advantage over using rules_pkg for debs etc - which is pretty well tested/maintained etc, and the google rpm packager - not against the idea in theory if there are some advantages

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!