Conversation
There was a problem hiding this comment.
We are behind on protobuf in the core dependency space. Should this version align with https://github.com/envoyproxy/envoy/blob/main/bazel/repository_locations.bzl#L597-L608 ?
There was a problem hiding this comment.
perhaps, altho im not sure if it matters that much for this client example
do you want me to downgrade it to 3.16.0 ?
There was a problem hiding this comment.
or perhaps we bump the bazel version for it instead
There was a problem hiding this comment.
ive bumped the protobuf version pulled in by bazel
There was a problem hiding this comment.
actually im reverting the bazel bump - it requires more than a simple update to the bazel files
also - afaict the protos in this example are built using
- https://hub.docker.com/layers/grpc/python/latest/images/sha256-6f0898ac290991eab0c262fa18453904f75286f17978d3185164d01400dc042e?context=explore
- https://hub.docker.com/layers/grpc/go/latest/images/sha256-0d3bb1fbfab306680ebaf751992bd2db2a0322106e4b389e85028a027242c2bc?context=explore
these are more than 3 years old and use v3.6.0
imho we probably still want to bump the client library
|
seems like there is another update for codeql/action ill update tomorrow /wait |
Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 3.17.2 to 3.17.3. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/master/generate_changelog.py) - [Commits](protocolbuffers/protobuf@v3.17.2...v3.17.3) --- updated-dependencies: - dependency-name: protobuf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Bumps [actions/stale](https://github.com/actions/stale) from 3.0.14 to 3.0.19. - [Release notes](https://github.com/actions/stale/releases) - [Commits](actions/stale@v3.0.14...v3.0.19) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from cb5810848de15b695cd9ef3b559dd178c43c7df3 to 1.0.2. This release includes the previously tagged commit. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@cb58108...a66b44a) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
ba04ec4 to
3e60fba
Compare
9bc0f25 to
3e60fba
Compare
|
/lgtm deps |
Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ryan Northey <ryan@synca.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Commit Message: dependabot: Updates
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]