dns cache: add ability to prefetch hostnames to resolve during cache construction#16891
Merged
alyssawilk merged 16 commits intoenvoyproxy:mainfrom Jun 21, 2021
junr03:dns_warmup
Merged
dns cache: add ability to prefetch hostnames to resolve during cache construction#16891alyssawilk merged 16 commits intoenvoyproxy:mainfrom junr03:dns_warmup
alyssawilk merged 16 commits intoenvoyproxy:mainfrom
junr03:dns_warmup
Conversation
added 6 commits
June 7, 2021 16:55
Signed-off-by: Jose Nino <jnino@lyft.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
junr03
changed the title
dmitri-d
reviewed
Jun 9, 2021
source/extensions/common/dynamic_forward_proxy/dns_cache_impl.cc
Outdated
Show resolved
Hide resolved
Member
Author
|
@zuercher I am the author. Will need another assignee. |
Contributor
|
/lgtm api |
alyssawilk
reviewed
Jun 14, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
@junr03 looks like you need a format fix.
Also as a reminder I'm out from tomorrow through next week so if you need a pass after today you'll want to find an alternate reviewer (I trust you can do so so I won't tag someone for you =P)
api/envoy/extensions/common/dynamic_forward_proxy/v3/dns_cache.proto
Outdated
Show resolved
Hide resolved
source/extensions/common/dynamic_forward_proxy/dns_cache_impl.cc
Outdated
Show resolved
Hide resolved
source/extensions/common/dynamic_forward_proxy/dns_cache_impl.cc
Outdated
Show resolved
Hide resolved
alyssawilk
reviewed
Jun 14, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Looking good! don't forget release notes! :-)
api/envoy/extensions/common/dynamic_forward_proxy/v3/dns_cache.proto
Outdated
Show resolved
Hide resolved
source/extensions/common/dynamic_forward_proxy/dns_cache_impl.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Jose Nino <jnino@lyft.com>
junr03
changed the title
alyssawilk
reviewed
Jun 14, 2021
added 4 commits
June 14, 2021 15:04
alyssawilk
previously approved these changes
Jun 14, 2021
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
@mattklein123 can I get a stamp? @alyssawilk had approved but I had a clang-tidy error and a type fix for windows after that. |
Contributor
|
/lgtm api |
alyssawilk
approved these changes
Jun 21, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…construction (envoyproxy#16891) Commit Message: this PR adds the ability to prefetch hostnames to resolve during cache construction. Additional Description: This feature can be used as a performance improvement for setups that use dns cache, but know a priori some of the hostnames that will be used. Risk Level: low -- adds a feature that is off by default. Testing: new tests Docs Changes: added documentation in the API Release Notes: inline Signed-off-by: Jose Nino <jnino@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: this PR adds the ability to prefetch hostnames to resolve during cache construction.
Additional Description: This feature can be used as a performance improvement for setups that use dns cache, but know a priori some of the hostnames that will be used.
Risk Level: low -- adds a feature that is off by default.
Testing: new tests
Docs Changes: added documentation in the API
Release Notes: pending.