Skip to content

python: Remove unused dependencies#16839

Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
phlax:py-thin-deps
Jun 8, 2021
Merged

python: Remove unused dependencies#16839
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
phlax:py-thin-deps

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jun 7, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: python: Remove unused dependencies
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 7, 2021
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16839 was opened by phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 7, 2021

@moderation theres a good example here of why its not really feasible to have a python mod tidy

in this env pep8-naming is required, but its not imported anywhere and there's no reliable way you could tell by analysis that its required here

obv this is a bit of a meta example, but the same would hold for any plugins that change how a dependency works but are not invoked directly

@phlax phlax requested a review from moderation June 7, 2021 09:55
@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jun 7, 2021
@mattklein123 mattklein123 merged commit 37230ba into envoyproxy:main Jun 8, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants