thrift_proxy: remove well_known_names#16837
Merged
zuercher merged 2 commits intoenvoyproxy:mainfrom Jun 8, 2021
Merged
Conversation
zuercher
reviewed
Jun 7, 2021
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
I noted the source of the compilation error below. Also, I think we can outright delete well_known_names.h in this PR as well. (I think that step may have been missed in some of your other PRs as well.)
test/extensions/filters/network/thrift_proxy/filters/ratelimit/ratelimit_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Long Dai <long0dai@foxmail.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
zuercher
approved these changes
Jun 8, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Remove well_known_names in thrift_proxy field, part of envoyproxy#7238 Risk Level: Low Testing: functional Docs Changes: n/a Release Notes: n/a Signed-off-by: Long Dai <long0dai@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Long Dai long0dai@foxmail.com
Commit Message:
Remove well_known_names in thrift_proxy field, part of #7238
Additional Description:
Risk Level: Low
Testing: functional
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]