Skip to content

Revert bandaid for gcc CI build #16818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 2 commits into from
Jun 7, 2021
Merged

Revert bandaid for gcc CI build #16818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e9eac9
Revert bandiad for gcc CI build
yanavlasov Jun 4, 2021
d383b0e
Merge branch 'main' into revert-gcc-bandaid
yanavlasov Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions ci/do_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,20 +218,11 @@ elif [[ "$CI_TARGET" == "bazel.sizeopt" ]]; then
bazel_binary_build sizeopt
exit 0
elif [[ "$CI_TARGET" == "bazel.gcc" ]]; then
# Temporariliy exclude some extensions from the envoy binary to address build failures
# due to long command line. Tests will still run.
BAZEL_BUILD_OPTIONS+=(
"--test_env=HEAPCHECK="
"--//source/extensions/filters/network/rocketmq_proxy:enabled=False"
"--//source/extensions/filters/http/admission_control:enabled=False"
"--//source/extensions/filters/http/dynamo:enabled=False"
"--//source/extensions/filters/http/header_to_metadata:enabled=False"
"--//source/extensions/filters/http/on_demand:enabled=False")
BAZEL_BUILD_OPTIONS+=("--test_env=HEAPCHECK=")
setup_gcc_toolchain

# Disable //test/config_test:example_configs_test so it does not fail because of excluded extensions above
echo "Testing ${TEST_TARGETS[*]} -//test/config_test:example_configs_test"
bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c fastbuild -- "${TEST_TARGETS[@]}" -//test/config_test:example_configs_test
echo "Testing ${TEST_TARGETS[*]}"
bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c fastbuild -- "${TEST_TARGETS[@]}"

echo "bazel release build with gcc..."
bazel_binary_build fastbuild
Expand Down