Skip to content

deps: Remove unused dependencies from gh notifier#16813

Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
phlax:deps-gh-pr-notifier
Jun 7, 2021
Merged

deps: Remove unused dependencies from gh notifier#16813
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
phlax:deps-gh-pr-notifier

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jun 4, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: deps: Remove unused dependencies from gh notifier
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 4, 2021
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16813 was opened by phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 4, 2021

afaict not all of the deps in requirements.txt were used

i regenerated the file by removing everything apart from pygithub and slack-sdk and then reran pip-compile

@moderation
Copy link
Copy Markdown
Contributor

I was wondering if their was a pip equivalent of something like go mod tidy that would remove unnecessary deps

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 4, 2021

not sure what go mod tidy does exactly but i dont know of any deps analysis tools that tell what is actually used in a set of given scripts or an env

in this case, there is only one script and it only has a couple of non-stdlib imports, so im pretty sure most of these deps are not required

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 4, 2021

i guess a difference between go and python is that with go you can ask "what is required to compile x binary" whereas in python its more like "what is going to be used in this env" which is more open-ended

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 5, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16813 (comment) was created by @phlax.

see: more, trace.

@phlax phlax force-pushed the deps-gh-pr-notifier branch from 6ceecc7 to 88cf75d Compare June 5, 2021 11:20
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 5, 2021

ive updated this pr to incorporate bumping slack-sdk to v3.6

@phlax phlax requested a review from moderation June 5, 2021 11:27
@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jun 5, 2021
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks

@alyssawilk alyssawilk merged commit d85278a into envoyproxy:main Jun 7, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants