deps: Remove unused dependencies from gh notifier#16813
deps: Remove unused dependencies from gh notifier#16813alyssawilk merged 1 commit intoenvoyproxy:mainfrom
Conversation
|
afaict not all of the deps in requirements.txt were used i regenerated the file by removing everything apart from |
|
I was wondering if their was a |
|
not sure what in this case, there is only one script and it only has a couple of non-stdlib imports, so im pretty sure most of these deps are not required |
|
i guess a difference between go and python is that with go you can ask "what is required to compile x binary" whereas in python its more like "what is going to be used in this env" which is more open-ended |
|
/retest |
|
Retrying Azure Pipelines: |
6ceecc7 to
88cf75d
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
88cf75d to
c768be9
Compare
|
ive updated this pr to incorporate bumping slack-sdk to v3.6 |
|
/lgtm deps |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: deps: Remove unused dependencies from gh notifier
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]