Skip to content

http: add test to ensure stream info populated into http stream #16797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggreenway merged 1 commit into from
Jun 7, 2021
Merged

http: add test to ensure stream info populated into http stream #16797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions test/common/http/conn_manager_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,30 @@ TEST_F(HttpConnectionManagerImplTest, 100ContinueResponseWithDecoderPause) {
EXPECT_EQ(2U, listener_stats_.downstream_rq_completed_.value());
}

// When create new stream, the stream info will be populated from the connection.
TEST_F(HttpConnectionManagerImplTest, PopulateStreamInfo) {
setup(true, "", false);

absl::string_view server_name = "fake-server";
EXPECT_CALL(filter_callbacks_.connection_, id()).WillRepeatedly(Return(1234));
EXPECT_CALL(filter_callbacks_.connection_, requestedServerName())
.WillRepeatedly(Return(server_name));

// Set up the codec.
Buffer::OwnedImpl fake_input("input");
conn_manager_->createCodec(fake_input);

decoder_ = &conn_manager_->newStream(response_encoder_);

EXPECT_EQ(requestIDExtension().get(), decoder_->streamInfo().getRequestIDProvider());
EXPECT_EQ(ssl_connection_, decoder_->streamInfo().downstreamSslConnection());
EXPECT_EQ(1234, decoder_->streamInfo().connectionID());
EXPECT_EQ(server_name, decoder_->streamInfo().requestedServerName());

// Clean up.
filter_callbacks_.connection_.raiseEvent(Network::ConnectionEvent::RemoteClose);
}

// By default, Envoy will set the server header to the server name, here "custom-value"
TEST_F(HttpConnectionManagerImplTest, ServerHeaderOverwritten) {
setup(false, "custom-value", false);
Expand Down