docs: add seealso section to gzip sandbox#16796
Merged
phlax merged 5 commits intoenvoyproxy:mainfrom Jun 8, 2021
Merged
Conversation
Signed-off-by: Long Dai <long0dai@foxmail.com>
Member
|
looks good @daixiang0 - could we also add a link to the gzip api docs please |
Signed-off-by: Long Dai <long0dai@foxmail.com>
phlax
reviewed
Jun 3, 2021
phlax
reviewed
Jun 3, 2021
rojkov
reviewed
Jun 4, 2021
Signed-off-by: Long Dai <long0dai@foxmail.com>
Member
|
rendered docs are here https://storage.googleapis.com/envoy-pr/16796/docs/index.html @daixiang0 could you fix format please |
Member
|
probably you want to adjust your editor so these dont happen |
phlax
requested changes
Jun 7, 2021
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
almost there @daixiang0 a few nits below...
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Long Dai <long0dai@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Long Dai long0dai@foxmail.com
Commit Message:
Add seealso section to gzip sandbox
Additional Description:
Risk Level: LOW
Testing:
Docs Changes: add seealso section.
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #16748
[Optional Deprecated:]
[Optional API Considerations:]