Closed
Conversation
Signed-off-by: Matt Klein <mklein@lyft.com>
repokitteh-read-only
bot
added
the
deps
Member
Author
|
@alyssawilk I think it's pretty much as easy as this. Right now I have it running on PR just to test it, but then we can switch it over to both a cron and manual dispatch. I can also help you with the secrets offline. |
Member
Author
|
cc @phlax also |
phlax
reviewed
Jun 1, 2021
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r ./.github/actions/pr_notifier/requirements.txt |
Member
There was a problem hiding this comment.
+1 - the pip installer i linked doesnt support require-hashes afaict - this sees to be the most straightforward
Contributor
|
Nice!! |
Member
|
I am not sure whether it can be replaced by this tool. |
Member
Author
|
I'm just going to close this. @alyssawilk this is simple enough let's just merge this into your other PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.