extensions: Use bazel build for generating docs rst#16749
extensions: Use bazel build for generating docs rst#16749phlax merged 2 commits intoenvoyproxy:mainfrom
Conversation
repokitteh-read-only
bot
added
the
deps
phlax
force-pushed
the
extensions-rstgen
branch
3 times, most recently
from
d5cc718 to
e2b097c
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
changed the title
| pip_install( | ||
| name = "docs_pip3", | ||
| requirements = "@envoy//tools/docs:requirements.txt", | ||
| extra_pip_args = ["--require-hashes"], | ||
| ) |
There was a problem hiding this comment.
What are your thoughts on capturing metadata for the Python deps? I added this data as comments with an example at https://github.com/envoyproxy/envoy/blob/main/bazel/repositories_extra.bzl#L26-L37. Some issues:
- some new deps don't have this data
- no automated checkers
- not machine readable
- duplicitive
There was a problem hiding this comment.
yep - mostly the issues - ie hard to maintain and in some cases it just duplicates what is there in the egg
There was a problem hiding this comment.
Thinking maybe we remove the existing comment metadata until we think we need a better solution and agree on a way to do it? (doesn't have to be in this PR which looks like it is on its way to passing CI)
There was a problem hiding this comment.
sure - im happy to follow that up after
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
Signed-off-by: Ryan Northey <ryan@synca.io>
3 participants
Commit Message: extensions: Use bazel build for generating docs rst
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]