Skip to content

internal_redirect: remove well_known_names#16746

Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
daixiang0:internal_redirect
Jun 1, 2021
Merged

internal_redirect: remove well_known_names#16746
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
daixiang0:internal_redirect

Conversation

@daixiang0
Copy link
Copy Markdown
Member

Signed-off-by: Long Dai long0dai@foxmail.com

Commit Message:

Remove well_known_names in internal_redirect field, part of #7238

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Long Dai <long0dai@foxmail.com>
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Will merge as is but next time mind filling out the PR template for easier merging?

@alyssawilk alyssawilk merged commit 1c03ddc into envoyproxy:main Jun 1, 2021
@daixiang0
Copy link
Copy Markdown
Member Author

@alyssawilk got it, thanks for kind input

@daixiang0 daixiang0 deleted the internal_redirect branch June 2, 2021 00:25
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Long Dai <long0dai@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants