Skip to content

build: Enable JIT and optimize the WAMR for envoy#16739

Merged
lizan merged 5 commits intoenvoyproxy:mainfrom
leyao-daily:main
Jul 8, 2021
Merged

build: Enable JIT and optimize the WAMR for envoy#16739
lizan merged 5 commits intoenvoyproxy:mainfrom
leyao-daily:main

Conversation

@leyao-daily
Copy link
Copy Markdown
Member

JIT Mode can be open now. Finish the optimization of WAMR for Envoy

Co-authored-by: Liang He liang.he@intel.com
Signed-off-by: Le Yao le.yao@intel.com

Commit Message: Enable JIT and optimize the WAMR for envoy
Additional Description: JIT Mode can be open now. Finish the optimization of WAMR for Envoy
Risk Level: Low
Testing: WIP
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 1, 2021
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16739 was opened by leyao-daily.

see: more, trace.

@junr03
Copy link
Copy Markdown
Member

junr03 commented Jun 2, 2021

Hi @leyao-daily I noticed this PR is in Draft. Would you like me to assign a maintainer to start the code review process, or wait until you mark ready for review?

/wait-any

@leyao-daily
Copy link
Copy Markdown
Member Author

Hi @leyao-daily I noticed this PR is in Draft. Would you like me to assign a maintainer to start the code review process, or wait until you mark ready for review?

/wait-any

I still work on some local tests. I think it can be reviewed after I finish testing and mark it ready for review. Thanks

@alyssawilk
Copy link
Copy Markdown
Contributor

Just to be aware, we've been making some improvements to Envoy tooling for more prompt reviews, but draft PRs are not included in the tooling. I'm updating the contribution guidelines to make that clear (https://github.com/envoyproxy/envoy/pull/17063/files) , but as this PR predates the repokitteh warning I just want to call out that draft PRs are likely not going to get fast turnaround. Please consider marking this as ready for review if it stalls, and you want the assignee to take a look!

Le Yao and others added 2 commits July 4, 2021 21:25
JIT Mode can be open now. And the optimization

Co-authored-by: Liang He <liang.he@intel.com>
Signed-off-by: Le Yao <le.yao@intel.com>
Signed-off-by: Le Yao <le.yao@intel.com>
@leyao-daily leyao-daily force-pushed the main branch 3 times, most recently from 6b542ac to 88e3bd4 Compare July 5, 2021 06:10
Signed-off-by: Le Yao <le.yao@intel.com>
@leyao-daily leyao-daily force-pushed the main branch 2 times, most recently from fdd4dfa to 3061597 Compare July 6, 2021 02:49
@leyao-daily leyao-daily marked this pull request as ready for review July 6, 2021 03:12
@leyao-daily leyao-daily force-pushed the main branch 3 times, most recently from 2078d1f to 932c867 Compare July 6, 2021 06:43
Signed-off-by: Le Yao <le.yao@intel.com>
@leyao-daily leyao-daily force-pushed the main branch 2 times, most recently from 8adf201 to 3f2bc80 Compare July 6, 2021 08:19
@leyao-daily leyao-daily requested a review from lizan as a code owner July 6, 2021 08:19
@leyao-daily leyao-daily requested a review from PiotrSikora as a code owner July 6, 2021 08:19
Signed-off-by: Le Yao <le.yao@intel.com>
@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jul 7, 2021
@leyao-daily leyao-daily requested a review from PiotrSikora July 7, 2021 01:41
@leyao-daily
Copy link
Copy Markdown
Member Author

I think it's ready to merge. Thanks :)

@leyao-daily
Copy link
Copy Markdown
Member Author

@PiotrSikora Thanks for your comments. I have update to the latest commit. And can you help review it. LOL Thanks. :)

@lizan lizan merged commit 2b14b88 into envoyproxy:main Jul 8, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
JIT Mode can be open now. Finish the optimization of WAMR for Envoy

Risk Level: Low

Co-authored-by: Liang He <liang.he@intel.com>
Signed-off-by: Le Yao <le.yao@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants