Update ABSL to latest LTS version 20210324.2

[yanavlasov]

Signed-off-by: Yan Avlasov yavlasov@google.com

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16681 was opened by yanavlasov.

see: more, trace.

[moderation]

This PR may replace the abseil component of #16293 - @kyessenov

[moderation]

/lgtm deps

[wrowe]

This appears to be a breaking change on windows, please review and escalate for consideration...
'''
ERROR: C:/source/source/common/quic/BUILD:223:17: Compiling source/common/quic/envoy_quic_server_stream.cc failed: (Exit 2): cl.exe failed: error executing command
cd C:/build/tmp/execroot/envoy
SET INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29910\include;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\ucrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\cppwinrt
SET PATH=C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29910\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\VC\VCPackages;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\bin\Roslyn;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\Tools\devinit;C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\Bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\Tools;;C:\Windows\system32
SET PWD=/proc/self/cwd
SET TEMP=C:\Windows\Temp
SET TMP=C:\Windows\Temp
SET TMPDIR=C:\Windows\Temp
SET USE_CLANG_CL=
C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.28.29910/bin/HostX64/x64/cl.exe @bazel-out/x64_windows-opt/bin/source/common/quic/_objs/envoy_quic_server_session_lib/envoy_quic_server_stream.obj.params
Execution platform: @rbe_windows_msvc_cl//config:platform
external\com_google_absl\absl/types/compare.h(49): error C2338: Only literal 0 is allowed.
external\com_google_absl\absl/types/optional.h(711): note: see reference to class template instantiation 'absl::lts_20210324::compare_internal::Fail' being compiled
with
[
T=bool
]
'''

[yanavlasov]

We should fix the it here:

envoy/source/common/quic/envoy_quic_client_stream.cc

Line 316 in b42563c

void EnvoyQuicClientStream::onStreamError(absl::optional<bool> should_close_connection,

I have pinged @danzh2010 about changing this as the absl::optional is extraneous.

[danzh2010]

We should fix the it here:

envoy/source/common/quic/envoy_quic_client_stream.cc

Line 316 in b42563c

void EnvoyQuicClientStream::onStreamError(absl::optional<bool> should_close_connection,

I have pinged @danzh2010 about changing this as the absl::optional is extraneous.

eliminating absl::optional is not feasible here. Can you try using has_value() instead of comparison with absl::nullopt?

[yanavlasov]

Obsolete by PR #16687