AlternateProtocolsCache: Add Mocks#16677
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Jun 1, 2021
Merged
Conversation
Signed-off-by: Ryan Hamilton <rch@google.com>
Contributor
Author
|
/assign @DavidSchinazi |
DavidSchinazi
approved these changes
May 26, 2021
| namespace Envoy { | ||
| namespace Http { | ||
|
|
||
| MockAlternateProtocolsCache::~MockAlternateProtocolsCache() = default; |
Contributor
There was a problem hiding this comment.
At this point I'd just define all this in the header file, but up to you. I don't know what the rest of Envoy does in this scenario.
Contributor
Author
There was a problem hiding this comment.
Yeah, I share your intuition. I followed the pattern for the other files in test/mock/http and put the = default in the .cc file.
Contributor
Author
|
/assign @alyssawilk |
alyssawilk
approved these changes
Jun 1, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Generally I'd suggest landing this where they're used, but all LGTM and I'll review it either way =P
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Add mocks of the various AlternateProtocolsCache classes. Risk Level: Low Testing: Test-only code Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Ryan Hamilton <rch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mocks of the various AlternateProtocolsCache classes.
Risk Level: Low
Testing: Test-only code
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A