stats: Remove empty segments from stat names during encoding#16675
Closed
jmarantz wants to merge 2 commits intoenvoyproxy:mainfrom
Closed
stats: Remove empty segments from stat names during encoding#16675jmarantz wants to merge 2 commits intoenvoyproxy:mainfrom
jmarantz wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…g dot tests. Signed-off-by: Joshua Marantz <jmarantz@google.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Removes empty segments from stats during encoding. This clears up some ambiguities that triggered occasional fuzz issues in stat_merger_fuzz_test.
This is copied #16239 from @jessicayuen
Additional Description:
Risk Level: medium - I think generally empty names were not encoded in Envoy, but this can change how they are rendered as strings.
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a