http: refactory Http::Utility::resolveMostSpecificPerFilterConfig method#16673
Merged
alyssawilk merged 10 commits intoenvoyproxy:mainfrom Jun 1, 2021
Merged
Conversation
…cPerFilterConfigTyped Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
soulxu
requested review from
alyssawilk,
htuch,
lizan and
mattklein123
as code owners
alyssawilk
reviewed
May 26, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Nice find! Want to ping back when CI is happy and I'll take a look?
Member
Author
thanks for having a look at, let me make the CI happy first! |
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
alyssawilk
previously approved these changes
May 27, 2021
Contributor
|
looks like this needs a main merge though! |
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
htuch
reviewed
May 28, 2021
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Makes sense to me; this is less confusing. Will defer to @alyssawilk for full review. Thanks!
Member
Author
|
emm...coverage test failed. probably due to I removed few lines code. |
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
alyssawilk
approved these changes
Jun 1, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…hod (envoyproxy#16673) Commit Message: http: refactory Http::Utility::resolveMostSpecificPerFilterConfig method Additional Description: The Http::Utility::resolveMostSpecificPerFilterConfig and RouteEntry::mostSpecificPerFilterConfigTyped are doing the same thing. RouteEntry::mostSpecificPerFilterConfigTyped is more efficient, and Http::Utility::resolveMostSpecificPerFilterConfig can take care some of sanity checks. So converge them. Refactory Http::Utility::resolveMostSpecificPerFilterConfig to use RouteEntry::mostSpecificPerFilterConfigTyped. And using Http::Utility::resolveMostSpecificPerFilterConfig for the filters consistently. Risk Level: low Testing: unittest Docs Changes: n/a Release Notes: n/a Fixes envoyproxy#14894 Signed-off-by: He Jie Xu <hejie.xu@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: http: refactory
Http::Utility::resolveMostSpecificPerFilterConfigmethodAdditional Description:
The
Http::Utility::resolveMostSpecificPerFilterConfigandRouteEntry::mostSpecificPerFilterConfigTypedare doingthe same thing.
RouteEntry::mostSpecificPerFilterConfigTypedis more efficient, andHttp::Utility::resolveMostSpecificPerFilterConfigcan take care some of sanity checks. So converge them. RefactoryHttp::Utility::resolveMostSpecificPerFilterConfigto useRouteEntry::mostSpecificPerFilterConfigTyped. And usingHttp::Utility::resolveMostSpecificPerFilterConfigfor the filters consistently.Risk Level: low
Testing: unittest
Docs Changes: n/a
Release Notes: n/a
Fixes #14894