tests: fixing parameter type passed to is_optional#16669
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom May 26, 2021
Merged
tests: fixing parameter type passed to is_optional#16669lizan merged 1 commit intoenvoyproxy:mainfrom
lizan merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: fixing parameter type passed to is_optional
Additional Description:
A couple of tests passed a string
"true"to a boolean protobuf field.This PR changes the passed parameter to boolean.
Risk Level: Low - tests code only.
Testing: Updating tests.
Docs Changes: N/A.
Release Notes: N/A.
Platform Specific Features: N/A.
Signed-off-by: Adi Suissa-Peleg adip@google.com