Skip to content

quic: cleaning obsolete TODOS #16661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanavlasov merged 2 commits into from
May 26, 2021
Merged

quic: cleaning obsolete TODOS #16661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70f70e4
quic: cleaning obsolete TODOS
alyssawilk May 25, 2021
77eaf6a
format
alyssawilk May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/common/http/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,6 @@ envoy_cc_test(
],
)

# TODO(alyssawilk): The conn pool grid should work correctly without H3. Circle back and figure
# out the right way of handling the lack of H3 in the build.
envoy_cc_test(
name = "conn_pool_grid_test",
srcs = envoy_select_enable_http3(["conn_pool_grid_test.cc"]),
Expand Down
5 changes: 0 additions & 5 deletions test/integration/multiplexed_upstream_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,11 +333,6 @@ TEST_P(Http2UpstreamIntegrationTest, ManyLargeSimultaneousRequestWithBufferLimit
}

TEST_P(Http2UpstreamIntegrationTest, ManyLargeSimultaneousRequestWithRandomBackup) {
if (upstreamProtocol() == FakeHttpConnection::Type::HTTP3) {
// TODO(alyssawilk) debug and enable.
return;
}

config_helper_.addFilter(
fmt::format(R"EOF(
name: pause-filter{}
Expand Down
12 changes: 3 additions & 9 deletions test/integration/protocol_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,15 +526,9 @@ TEST_P(ProtocolIntegrationTest, Retry) {
EXPECT_EQ("200", response->headers().getStatusValue());
EXPECT_EQ(512U, response->body().size());
Stats::Store& stats = test_server_->server().stats();
if (upstreamProtocol() == FakeHttpConnection::Type::HTTP2) {
Stats::CounterSharedPtr counter =
TestUtility::findCounter(stats, "cluster.cluster_0.http2.tx_reset");
ASSERT_NE(nullptr, counter);
EXPECT_EQ(1L, counter->value());
} else if (upstreamProtocol() == FakeHttpConnection::Type::HTTP3) {
// TODO(alyssawilk) http3 stats.
Stats::CounterSharedPtr counter =
TestUtility::findCounter(stats, "cluster.cluster_0.upstream_rq_tx_reset");
if (upstreamProtocol() != FakeHttpConnection::Type::HTTP1) {
Stats::CounterSharedPtr counter = TestUtility::findCounter(
stats, absl::StrCat("cluster.cluster_0.", upstreamProtocolStatsRoot(), ".tx_reset"));
ASSERT_NE(nullptr, counter);
EXPECT_EQ(1L, counter->value());
}
Expand Down