kill_filter extension: fix use-after-free bug in kill filter and improve test coverage#16656
Merged
antoniovicente merged 5 commits intoenvoyproxy:mainfrom May 26, 2021
Merged
Conversation
Signed-off-by: Pradeep Rao <pcrao@google.com>
…ability in decodeHeaders Run formatter on kill_request dir Signed-off-by: Pradeep Rao <pcrao@google.com>
|
Hi @pradeepcrao, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
KBaichoo
reviewed
May 25, 2021
Contributor
KBaichoo
left a comment
KBaichoo
left a comment
There was a problem hiding this comment.
Thanks for adding this @pradeepcrao.
test/extensions/filters/http/kill_request/kill_request_filter_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
KBaichoo
reviewed
May 26, 2021
test/extensions/filters/http/kill_request/kill_request_filter_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Pradeep Rao <pcrao@google.com>
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
KBaichoo
approved these changes
May 26, 2021
Contributor
KBaichoo
left a comment
KBaichoo
left a comment
There was a problem hiding this comment.
lgtm. mind reviewing this @antoniovicente ? Thanks
Contributor
|
/assign @antoniovicente |
antoniovicente
approved these changes
May 26, 2021
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the fix and tests.
antoniovicente
changed the title
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…ove test coverage (envoyproxy#16656) Signed-off-by: Pradeep Rao <pcrao@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Coverage improvement and bug fix in kill filter.
Additional Description:
Risk Level: Low (test only)
Testing: Added unit test.
Docs Changes: NA
Release Notes: NA
Platform Specific Features: NA