Skip to content

bazel: update to v4.1.0.#16644

Merged
yanavlasov merged 3 commits intoenvoyproxy:mainfrom
PiotrSikora:bazel_v4.0.0
May 26, 2021
Merged

bazel: update to v4.1.0.#16644
yanavlasov merged 3 commits intoenvoyproxy:mainfrom
PiotrSikora:bazel_v4.0.0

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

@PiotrSikora PiotrSikora commented May 24, 2021

Signed-off-by: Piotr Sikora piotrsikora@google.com

@PiotrSikora
bazel: update to v4.0.0.
9960162 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 24, 2021
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented May 24, 2021

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16644 was opened by PiotrSikora.

see: more, trace.

@wrowe
Copy link
Copy Markdown
Contributor

wrowe commented May 24, 2021 •
edited
Loading

Can we hop skip and jump straight to 4.1.x?

I have a PR I'm fighting with to examine the next patch on master, we will need to pick that up, but I don't know that we are ready to jump beyond bazel 5.x now

@lizan lizan self-assigned this May 24, 2021
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented May 24, 2021

Can we hop skip and jump straight to 4.1.x?

Perhaps, but that would require new build image (see: envoyproxy/envoy-build-tools#135), which I was trying to avoid to minimize changes in this PR. Let's see if v4.0.0 passes CI first.

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented May 25, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented May 25, 2021

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16644 (comment) was created by @PiotrSikora.

see: more, trace.

@PiotrSikora PiotrSikora marked this pull request as ready for review May 25, 2021 08:36
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented May 25, 2021

Can we hop skip and jump straight to 4.1.x?

Perhaps, but that would require new build image (see: envoyproxy/envoy-build-tools#135), which I was trying to avoid to minimize changes in this PR. Let's see if v4.0.0 passes CI first.

Tests finally passed with v4.0.0, I think we can bump this to v4.1.0 once the build image PR is merged.

@moderation
Copy link
Copy Markdown
Contributor

moderation commented May 25, 2021

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label May 25, 2021
moderation
moderation suggested changes May 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update .bazelversion value

@PiotrSikora PiotrSikora changed the title bazel: update to v4.0.0. bazel: update to v4.1.0. May 25, 2021
@PiotrSikora
review: update to v4.1.0.
0656f21 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
review: update envoy-build-tools.
d4a1d8b 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 25, 2021
@moderation
Copy link
Copy Markdown
Contributor

moderation commented May 26, 2021

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label May 26, 2021
@yanavlasov yanavlasov merged commit 299eadf into envoyproxy:main May 26, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
@PiotrSikora
bazel: update to v4.1.0. (envoyproxy#16644)
7d830a6 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@moderation moderation moderation requested changes

@lizan lizan lizan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lizan lizan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PiotrSikora @wrowe @moderation @lizan @yanavlasov