configs: Remove unnecessary connect_timeouts#16641
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom May 27, 2021
Merged
configs: Remove unnecessary connect_timeouts#16641mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
phlax
changed the title
phlax
force-pushed
the
configs-remove-connect-timeout
branch
from
45f83dc to
9ed0d79
Compare
Member
Author
|
docs rendered here https://storage.googleapis.com/envoy-pr/16641/docs/index.html |
phlax
force-pushed
the
configs-remove-connect-timeout
branch
2 times, most recently
from
0a58be8 to
4af88ac
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
configs-remove-connect-timeout
branch
from
4af88ac to
dff3d3e
Compare
phlax
changed the title
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: configs: Remove unnecessary connect_timeouts
Additional Description:
now that there is a default for
connect_timeoutwe dont need to include it in all of the config examplesRisk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]