docs: Update redhat install instructions#16630
Conversation
…tenvoy with centos and rhel Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
|
/retest |
|
Retrying Azure Pipelines: |
phlax
left a comment
There was a problem hiding this comment.
thanks @ankatare for correcting these links
i also checked the links for the repos themselves and it appears they have also been merged
could you fix those links too ?
also - im thinking that given the instructions are now the same for rhel and centos can we collapse these two sets of instructions to one
|
i also checked the links for the repos themselves and it appears they have also been merged, could you fix those links too ? |
|
also - im thinking that given the instructions are now the same for rhel and centos can we collapse these two sets of instructions to one @phlax agree. i will do it |
the line like: |
|
@phlax Ok. Thanks.. i will do it. Just quick thing, i am thinking to do it in different PR, please suggest ? |
i think lets do it all here - im happy to review it and i think all of these issues stem from the same objective - ie updating the redhat install instructions to use the latest getenvoy |
|
@phlax Sure |
…centos in one Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
|
@phlax please suggest on current build failure. |
|
/retest |
|
Retrying Azure Pipelines: |
|
rendered docs are here https://storage.googleapis.com/envoy-pr/16630/docs/index.html |
unrelated windows flake i think |
Ok. Thanks for quick review @phlax |
|
@phlax just thinking, anything more need to be done to get it merged in main stream ? |
|
all good @ankatare - thanks - merged |
|
@phlax thanks a lot :) |
* reference issues in getting started doc for installing envoy using getenvoy with centos and rhel Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Commit Message: Reference url issues in getting started doc
Additional Description: NA
Risk Level: LOW
Testing: Unit
Docs Changes: Yes
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]