Skip to content

docs: Update redhat install instructions#16630

Merged
phlax merged 3 commits intoenvoyproxy:mainfrom
ankatare:ref_glich
May 25, 2021
Merged

docs: Update redhat install instructions#16630
phlax merged 3 commits intoenvoyproxy:mainfrom
ankatare:ref_glich

Conversation

@ankatare
Copy link
Copy Markdown
Contributor

Commit Message: Reference url issues in getting started doc
Additional Description: NA
Risk Level: LOW
Testing: Unit
Docs Changes: Yes
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

…tenvoy with centos and rhel

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16630 (comment) was created by @ankatare.

see: more, trace.

@phlax phlax self-assigned this May 24, 2021
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ankatare for correcting these links

i also checked the links for the repos themselves and it appears they have also been merged

could you fix those links too ?

also - im thinking that given the instructions are now the same for rhel and centos can we collapse these two sets of instructions to one

@ankatare
Copy link
Copy Markdown
Contributor Author

ankatare commented May 24, 2021

i also checked the links for the repos themselves and it appears they have also been merged, could you fix those links too ?
@phlax Sorry, i did not get here, which links are you reffering here ?

@ankatare
Copy link
Copy Markdown
Contributor Author

also - im thinking that given the instructions are now the same for rhel and centos can we collapse these two sets of instructions to one

@phlax agree. i will do it

@phlax
Copy link
Copy Markdown
Member

phlax commented May 24, 2021

which links are you reffering here ?

the line like:

$ sudo yum-config-manager --add-repo https://getenvoy.io/linux/rhel/tetrate-getenvoy.repo

@ankatare
Copy link
Copy Markdown
Contributor Author

@phlax Ok. Thanks.. i will do it.

Just quick thing, i am thinking to do it in different PR, please suggest ?

@phlax
Copy link
Copy Markdown
Member

phlax commented May 24, 2021

Just quick thing, i am thinking to do it in different PR, please suggest ?

i think lets do it all here - im happy to review it and i think all of these issues stem from the same objective - ie updating the redhat install instructions to use the latest getenvoy

@ankatare
Copy link
Copy Markdown
Contributor Author

@phlax Sure

…centos in one

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare
Copy link
Copy Markdown
Contributor Author

@phlax please suggest on current build failure.

@phlax
Copy link
Copy Markdown
Member

phlax commented May 25, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16630 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member

phlax commented May 25, 2021

rendered docs are here https://storage.googleapis.com/envoy-pr/16630/docs/index.html

@phlax phlax changed the title reference issues in getting started doc for installing envoy using ge… docs: Update redhat install instructions May 25, 2021
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks @ankatare

@phlax
Copy link
Copy Markdown
Member

phlax commented May 25, 2021

@phlax please suggest on current build failure.

unrelated windows flake i think

@ankatare
Copy link
Copy Markdown
Contributor Author

rendered docs are here https://storage.googleapis.com/envoy-pr/16630/docs/index.html

@phlax please suggest on current build failure.

unrelated windows flake i think

Ok. Thanks for quick review @phlax

@ankatare
Copy link
Copy Markdown
Contributor Author

@phlax just thinking, anything more need to be done to get it merged in main stream ?

@phlax phlax merged commit 8a824c4 into envoyproxy:main May 25, 2021
@phlax
Copy link
Copy Markdown
Member

phlax commented May 25, 2021

all good @ankatare - thanks - merged

@ankatare
Copy link
Copy Markdown
Contributor Author

@phlax thanks a lot :)

@ankatare ankatare deleted the ref_glich branch May 25, 2021 15:54
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
* reference issues in getting started doc for installing envoy using getenvoy with centos and rhel

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants