Refactor ip_detection_extensions to avoid cross extension dependencies.#16623
Merged
antoniovicente merged 1 commit intoenvoyproxy:mainfrom May 25, 2021
Merged
Refactor ip_detection_extensions to avoid cross extension dependencies.#16623antoniovicente merged 1 commit intoenvoyproxy:mainfrom
antoniovicente merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Contributor
Author
|
/assign @rgs1 |
rgs1
approved these changes
May 21, 2021
Member
rgs1
left a comment
rgs1
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up. LGTM once/if CI is happy.
Contributor
|
lgtm |
Contributor
Author
|
PTAL @envoyproxy/maintainers |
antoniovicente
approved these changes
May 25, 2021
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the test refactor.
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…s. (envoyproxy#16623) Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Baichoo kbaichoo@google.com
Commit Message:Refactor ip_detection_extensions to avoid cross extension dependencies.
Additional Description:
Risk Level: n/a test only
Testing: ran unit test
Docs Changes: NA
Release Notes: NA
Platform Specific Features: NA
I thought about putting this in the corresponding test/extension directories, but that'd require changing visibility of the packages which I haven't found elsewhere in test/extensions.