http: unifying client types#16606
Merged
alyssawilk merged 5 commits intoenvoyproxy:mainfrom May 27, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
requested review from
PiotrSikora,
antoniovicente,
asraa,
dio,
ggreenway,
htuch,
jmarantz,
lizan,
mattklein123,
snowp,
yanavlasov and
zuercher
as code owners
snowp
suggested changes
May 24, 2021
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Nice, thanks! One small comment
test/integration/fake_upstream.h
Outdated
| static absl::string_view typeToString(Type type) { | ||
| // This is a legacy alias. | ||
| using Type = Envoy::Http::CodecType; | ||
| // using Type = Envoy::Http::CodecType; |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
I think this PR is just too large for clang tidy to finish. @snowp would you be Ok if I just force-merge over that? |
Contributor
|
Fine with me as long as we don't break main as a result :) |
snowp
approved these changes
May 27, 2021
Contributor
Author
|
yeah, I think it's just timing out on the diffs. will revert if I'm wrong :-) |
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Unifying test upstream and client codec types, but leaving legacy typedefs for folks who don't want to update all their filters/tests. Risk Level: Low (enum change, theoretical legacy support) Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been a pet peeve of mine for years that the test upstream and test client have different enums for the same codecs.
Unifying them, but leaving legacy typedefs for folks who don't want to update all their filters/tests.
Risk Level: Low (enum change, theoretical legacy support)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a