test: cleaning up some H3 TODOs#16601
Merged
alyssawilk merged 6 commits intoenvoyproxy:mainfrom May 24, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
changed the title
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
oops - ran the wrong tests locally, this needs fixing. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
ah, nm, unrelated failure. merged main to pick up the latest fixes. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Risk Level: n/a (test only) Testing: manual Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If compiled out, H3 is automatically removed from getProtocolTestParams here
https://github.com/envoyproxy/envoy/blob/main/test/integration/http_protocol_integration.cc#L14
Risk Level: n/a (test only)
Testing: manual
Docs Changes: n/a
Release Notes: n/a