Add 3 members to CacheFilter owners list#16596
Merged
jmarantz merged 2 commits intoenvoyproxy:mainfrom May 23, 2021
Merged
Conversation
Signed-off-by: Josiah Kiehl <josiah@capoferro.net>
jmarantz
approved these changes
May 20, 2021
toddmgreer
approved these changes
May 20, 2021
Contributor
|
Can you merge main? Also, please don't force push in envoy PRs; it shouldn't matter for this one, but force-pushing drops PR comments. |
Contributor
Author
There were no comments when I force pushed, and the alternative was to create a new PR cause I needed to add the Signed-off-by line. I couldn't decide which would bother people less... force-pushing or closing and recreating the PR. Perhaps I chose wrong. |
Contributor
|
No problem! Just wanted to avoid dropping comments in the future :) You can set up a git hook to auto-add the signed-off line. |
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
@penguingao @mpwarres and myself are actively working on CacheFilter, bringing it up to RFC compliance among other functionality. Signed-off-by: Josiah Kiehl <josiah@capoferro.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@penguingao @mpwarres and myself are actively working on CacheFilter, bringing it up to RFC compliance among other functionality.